remove no-setuptools config option #9331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimbleby
force-pushed
the
no-no-setuptools
branch
from
51e628a
to
68aec9f
Compare
eamanu
approved these changes
Apr 23, 2024
Open
|
Given that
|
Secrus
approved these changes
Sep 15, 2024
|
@dimbleby could you please rebase? |
auto-merge was automatically disabled
September 15, 2024 11:40
Head branch was pushed to by a user without write access
dimbleby
force-pushed
the
no-no-setuptools
branch
from
1be2b44
to
f531897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is currently mildly inconsistent that poetry defaults to installing setuptools in newly created environments, but then removing it at
poetry install --syncthe direction of travel is that setuptools should be named as an explicit dependency if required, let's go there
maybe one for #9136 if that's going to be a thing, though personally I would not be too frightened of releasing this anyway, so long as it gets a suitable mention in the changelog